Fix prescribed velocity cookbooks for dc stokes #5396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjhei
reviewed
Sep 21, 2023
Comment on lines
272
to
277
| ((parameters.nonlinear_solver==Parameters<dim>::NonlinearSolver::no_Advection_iterated_defect_correction_Stokes || | ||
| parameters.nonlinear_solver==Parameters<dim>::NonlinearSolver::single_Advection_iterated_defect_correction_Stokes || | ||
| parameters.nonlinear_solver==Parameters<dim>::NonlinearSolver::iterated_Advection_and_defect_correction_Stokes || | ||
| parameters.nonlinear_solver==Parameters<dim>::NonlinearSolver::iterated_Advection_and_Newton_Stokes || | ||
| parameters.nonlinear_solver==Parameters<dim>::NonlinearSolver::single_Advection_iterated_Newton_Stokes) | ||
| && simulator_access.get_nonlinear_iteration() == 0) |
There was a problem hiding this comment.
would this work?
Suggested change
| ((parameters.nonlinear_solver==Parameters<dim>::NonlinearSolver::no_Advection_iterated_defect_correction_Stokes || | |
| parameters.nonlinear_solver==Parameters<dim>::NonlinearSolver::single_Advection_iterated_defect_correction_Stokes || | |
| parameters.nonlinear_solver==Parameters<dim>::NonlinearSolver::iterated_Advection_and_defect_correction_Stokes || | |
| parameters.nonlinear_solver==Parameters<dim>::NonlinearSolver::iterated_Advection_and_Newton_Stokes || | |
| parameters.nonlinear_solver==Parameters<dim>::NonlinearSolver::single_Advection_iterated_Newton_Stokes) | |
| && simulator_access.get_nonlinear_iteration() == 0) | |
| (simulator_access.get_nonlinear_iteration() == 0) |
There was a problem hiding this comment.
Yes, that works as well, thanks! I have update the pull request for both plugins
MFraters
force-pushed
the
fix_prescribed_velocity_cookbooks_for_DC_Stokes
branch
from
a435291
to
edcfeca
Compare
|
/rebuild |
gassmoeller
approved these changes
Sep 26, 2023
|
Looks good. The failing tester is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on a project I noticed that the prescribed velocities within the domain where a multiple of the prescribed value too high, and that the multiple was the number of nonlinear iterations. When using a defect correction Stokes (which includes the Newton Stokes), this should only be added at nonlinear iteration 0.
I am not sure if there is a cleaner way of checking this then what I am currently doing, so I am open to suggestions.