Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASPECT rename #5392

Merged
merged 1 commit into from
Sep 25, 2023
Merged

ASPECT rename #5392

merged 1 commit into from
Sep 25, 2023

Conversation

tjhei
Copy link
Member

@tjhei tjhei commented Sep 17, 2023

a proposed change for #5391

@gassmoeller gassmoeller mentioned this pull request Sep 18, 2023
Closed
jdannberg
jdannberg approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@jdannberg jdannberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

We have to change this for the website as well, right? Were you planning to do a separate PR for the www branch as well?

@tjhei
Copy link
Member Author

tjhei commented Sep 19, 2023

Yes. The website will need to be a separate PR and I was going to wait if we can find consensus.

@gassmoeller
Copy link
Member

Ok, I think we have left this open for comments long enough. Let's make it official. ASPECT has a new name 🎉

@gassmoeller gassmoeller merged commit 13a2e84 into geodynamics:main Sep 25, 2023
7 checks passed
@gassmoeller gassmoeller mentioned this pull request Sep 26, 2023
Merged
@tjhei tjhei deleted the rename branch September 28, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdannberg jdannberg jdannberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tjhei @gassmoeller @jdannberg