PB-1053: cog ignore alpha channel #1102
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having a big chunk of code that does the heavy lifting (loosely copied or similar in places like the load-kml and load-gpx plugin, plus the drag and drop handler) I gathered all this logic in one place, giving it the necessary options/config to handle all situation and be written only once. There is now only one way of dealing with a KML/KMZ/GPX file from external/local source, the dedicated parser. List of other things done while working on this : - changing updateLayer action to receive a layer ID instead of an index (was never used because of the hassle to get this index). I replaced uses of updateLayers when it was used for a single layer. - move all extent utils in... extentUtils.js - FileInput can now receive params for i18n placeholders in the error message - Fixing a missing rename with the local file disclaimer, it was not the correct tooltip shown for local files because of that - Adding a zoom to extent button in the layer list, if the layer provides an extent (meaning KML/GPX and soon COG)
renaming the layer type from GeoTIFF (which we shouldn't support much, too big of a risk of users loading very large files and crashing the app because of lack of memory) and clarifying that we support COG (Cloud Optimized GeoTIFF) Adding a dedicated parser for COG files improvements made during this work package : - read the no data value from the COG metadata (instead of arbitrarily setting it to zero) - re-load COG extent if the layer was added at startup through a URL param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.