PB-877: add swisssearch legacy url limit attribute #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-mapviewer
|
||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Run status |
|
| Run duration | 05m 26s |
| Commit |
|
| Committer | Felix Sommer |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
212
|
ltshb
reviewed
Oct 17, 2024
There was a problem hiding this comment.
I've two comprehension question that should be at least documented on the PR description:
- Why removing the
swisssearchurl parameter when it has been entered by the user ? What is the advantage of this ? If I read the ticket associated with this PR, the only issue that we have is that when a user is entering a search text in the search bar theswisssearchis set, so the changes should be very straight forward by not syncing store to url param, but only url param to store. - Why adding this strange limit support and how it works ? from where does it come from ? is it documented ? I could not find anything in ticket related to this ? Based on the PR title it is a legacy attribute so it should be in the legacy url param parser or has it been decided to keep this as official ?
Also the PR title only reflect the limit attribute but not the changes asked in ticket.
| @@ -147,6 +169,7 @@ const actions = { | |||
| * @param {SearchResult} entry | |||
| */ | |||
| selectResultEntry: ({ dispatch, getters, rootState }, { entry, dispatcher }) => { | |||
| console.log('selectResultEntry', entry) | |||
There was a problem hiding this comment.
Don't use console.log but log.debug from the log library
ltshb
requested changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link