PB 887 Fix dockerfile to use pipenv sync instead of install #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of the legacy docker-compose
The docker build command failed when it was done via `pipenv install`. Instead, we use the Pipenv.lock file and the `pipenv sync` command to install the dependencies for the docker container
hansmannj
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Thanks for fixing.
If I understood correctly, sync makes sense here, as it will install the exact versions of the Pipfile, while install might try to use newer versions.
So IMHO the service should work fine with the changes you suggest.
The tests seem to pass, which is a good sign 😉
ltshb
approved these changes
Aug 14, 2024
schtibe
changed the title
ltshb
added a commit
that referenced
this pull request
Sep 17, 2024
Due to last PR #73 the docker image was missing all dependencies because pipenv sync install dependencies in virtual environment. To solve this we moved to build stages which also fix a security issue in which we had pipenv installed in container image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticing that the build fail on my last PR I did a little digging on why this is happening. I was able to reproduce the problem locally (
docker build .). The offending line is the one wherepipenvinstalls the dependencies.I compared the
Dockerfileto the one inservice-stacand noticed that inservice-stacthe commandsyncis used together with thePipfile.lockfile, which to me makes total sense, so I changed it here too.Now since I have no clue about
service-kmlI don't know if this is a good idea and how to test if it still works.