PB-302: Add icon size to metadata

[LukasJoss]

No description provided.

[ltshb]

Before merging this, we should change the CI to use the new codebuild project way (so we can test it with this PR 😉 ) it is a very quick task, see PB-837 ticket. You can see this 2 recent PR were I did this work for qrcode;

• https://github.com/geoadmin/infra-terraform-github-bgdi/pull/105
• https://github.com/geoadmin/infra-terraform-bgdi-builder/pull/276

Beside that, in a separate PR we should also update python to 3.12 and all its dependencies before re-deploying service-icons (only do this if no big issues with newer version but I don't expect any) so we keep the service most up to date.

[hansmannj]

Those 2 lines can be deleted I guess

[ltshb]

What about for request with scale bigger than 1, the service should resize (even though currently not used).

[hansmannj]

Thanks, LGTM.
Only one thing: we should have a kind of versioning in the path.
We cannot change the path of the old icon sets, for backwards compatibility.
But for the new sets, we should add a v2 or a timestamp, e.g. 2024-09 or the like to the path.

[ltshb]

Just implement the case where scale is bigger than 1.

[ltshb]

Thanks, LGTM. Only one thing: we should have a kind of versioning in the path. We cannot change the path of the old icon sets, for backwards compatibility. But for the new sets, we should add a v2 or a timestamp, e.g. 2024-09 or the like to the path.

I think this is out of scope of this PR and needs to be refined.

[ltshb]

Here you should take the size from your function not the hardcoded 48px, so the code works if we have in future non 48px icons and also if the icon are not squared:

if scale != 1:
  new_size = icon.get_size().map(s => s * scale)
  image = image.resize(new_size)