Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update index.Rmd #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update index.Rmd #2

wants to merge 1 commit into from

Conversation

coconn41
Copy link

I am unable to run your code because all of the files you use are located on your personal machine. You should find a way to code so they are downloaded within the script, and thus can be referenced by anyone using the same code. I also made other small changes that are best practice suggestions.

coconn41
coconn41 commented Nov 19, 2020
View reviewed changes
index.Rmd
@@ -27,6 +27,7 @@ I loaded required packages

```{r, message=F, warning=F}
library(raster)
library(threejs)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call all packages at beginning of your code so that others may see what packages they need without searching through the rest of your code.

coconn41
coconn41 commented Nov 19, 2020
View reviewed changes
index.Rmd
@@ -38,6 +39,7 @@ library(caret)
library(forcats)
library(sp)
library(raster)
library(csvread)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call all packages at beginning of your code so that others may see what packages they need without searching through the rest of your code.

coconn41
coconn41 commented Nov 19, 2020
View reviewed changes
index.Rmd
#This first part of the plot is an example on how it works with Landsat data for Earth
Band1 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/B02.tif")
Band1 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/B02.tif")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my main comment. This raster is located on your personal machine, preventing myself or anyone else from running the code. It renders the rest of your code and analysis unable to run as well.

coconn41
coconn41 commented Nov 19, 2020
View reviewed changes
index.Rmd
Band5 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/B06.tif")
Band6 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/B07.tif")
Band7 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/B08.tif")
Band2 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/B03.tif")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my main comment. This raster is located on your personal machine, preventing myself or anyone else from running the code. It renders the rest of your code and analysis unable to run as well.

coconn41
coconn41 commented Nov 19, 2020
View reviewed changes
index.Rmd
Band6 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/B07.tif")
Band7 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/B08.tif")
Band2 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/B03.tif")
Band3 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/B04.tif")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my main comment. This raster is located on your personal machine, preventing myself or anyone else from running the code. It renders the rest of your code and analysis unable to run as well.

coconn41
coconn41 commented Nov 19, 2020
View reviewed changes
index.Rmd
Band7 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/B08.tif")
Band2 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/B03.tif")
Band3 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/B04.tif")
Band4 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/B05.tif")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my main comment. This raster is located on your personal machine, preventing myself or anyone else from running the code. It renders the rest of your code and analysis unable to run as well.

coconn41
coconn41 commented Nov 19, 2020
View reviewed changes
index.Rmd
Band2 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/B03.tif")
Band3 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/B04.tif")
Band4 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/B05.tif")
Band5 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/B06.tif")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my main comment. This raster is located on your personal machine, preventing myself or anyone else from running the code. It renders the rest of your code and analysis unable to run as well.

coconn41
coconn41 commented Nov 19, 2020
View reviewed changes
index.Rmd
Band3 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/B04.tif")
Band4 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/B05.tif")
Band5 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/B06.tif")
Band6 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/B07.tif")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my main comment. This raster is located on your personal machine, preventing myself or anyone else from running the code. It renders the rest of your code and analysis unable to run as well.

coconn41
coconn41 commented Nov 19, 2020
View reviewed changes
index.Rmd
Band4 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/B05.tif")
Band5 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/B06.tif")
Band6 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/B07.tif")
Band7 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/B08.tif")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my main comment. This raster is located on your personal machine, preventing myself or anyone else from running the code. It renders the rest of your code and analysis unable to run as well.

coconn41
coconn41 commented Nov 19, 2020
View reviewed changes
index.Rmd
band7 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b07.tiff")
band8 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b08.tiff")
band9 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b09.tiff")
band1 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b01.tiff")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my main comment. This raster is located on your personal machine, preventing myself or anyone else from running the code. It renders the rest of your code and analysis unable to run as well.

coconn41
coconn41 commented Nov 19, 2020
View reviewed changes
index.Rmd
band8 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b08.tiff")
band9 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b09.tiff")
band1 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b01.tiff")
band2 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b02.tiff")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my main comment. This raster is located on your personal machine, preventing myself or anyone else from running the code. It renders the rest of your code and analysis unable to run as well.

coconn41
coconn41 commented Nov 19, 2020
View reviewed changes
index.Rmd
band9 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b09.tiff")
band1 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b01.tiff")
band2 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b02.tiff")
band3 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b03.tiff")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my main comment. This raster is located on your personal machine, preventing myself or anyone else from running the code. It renders the rest of your code and analysis unable to run as well.

coconn41
coconn41 commented Nov 19, 2020
View reviewed changes
index.Rmd
band1 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b01.tiff")
band2 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b02.tiff")
band3 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b03.tiff")
band4 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b04.tiff")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my main comment. This raster is located on your personal machine, preventing myself or anyone else from running the code. It renders the rest of your code and analysis unable to run as well.

coconn41
coconn41 commented Nov 19, 2020
View reviewed changes
index.Rmd
band2 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b02.tiff")
band3 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b03.tiff")
band4 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b04.tiff")
band5 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b05.tiff")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my main comment. This raster is located on your personal machine, preventing myself or anyone else from running the code. It renders the rest of your code and analysis unable to run as well.

coconn41
coconn41 commented Nov 19, 2020
View reviewed changes
index.Rmd
band3 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b03.tiff")
band4 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b04.tiff")
band5 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b05.tiff")
band6 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b06.tiff")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my main comment. This raster is located on your personal machine, preventing myself or anyone else from running the code. It renders the rest of your code and analysis unable to run as well.

coconn41
coconn41 commented Nov 19, 2020
View reviewed changes
index.Rmd
band4 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b04.tiff")
band5 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b05.tiff")
band6 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b06.tiff")
band7 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b07.tiff")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my main comment. This raster is located on your personal machine, preventing myself or anyone else from running the code. It renders the rest of your code and analysis unable to run as well.

coconn41
coconn41 commented Nov 19, 2020
View reviewed changes
index.Rmd
band5 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b05.tiff")
band6 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b06.tiff")
band7 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b07.tiff")
band8 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b08.tiff")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my main comment. This raster is located on your personal machine, preventing myself or anyone else from running the code. It renders the rest of your code and analysis unable to run as well.

coconn41
coconn41 commented Nov 19, 2020
View reviewed changes
index.Rmd
band6 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b06.tiff")
band7 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b07.tiff")
band8 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b08.tiff")
band9 <- raster("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/selection_of_landingMining_sites/b09.tiff")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my main comment. This raster is located on your personal machine, preventing myself or anyone else from running the code. It renders the rest of your code and analysis unable to run as well.

coconn41
coconn41 commented Nov 19, 2020
View reviewed changes
index.Rmd
library(threejs)
library(csvread)
the_martian <- read.csv("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/visualize_of_landingMining_sites/the_martian.csv", comment.char="#")
the_martian <- read.csv("C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/visualize_of_landingMining_sites/the_martian.csv", comment.char="#")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my main comment. This raster is located on your personal machine, preventing myself or anyone else from running the code. It renders the rest of your code and analysis unable to run as well.

coconn41
coconn41 commented Nov 19, 2020
View reviewed changes
index.Rmd

#the_martian.csv <- ("C:/Users/Owner/Desktop/sare backup/c/user #hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/visualize_of_landi#ngMining_sites/the_martian.cvs")


globejs(img = "C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/visualize_of_landingMining_sites/Mars_Viking_MDIM21_ClrMosaic_global_1024.jpg", bodycolor="#555555", emissive="#444444",
globejs(img = "C:/Users/Owner/Desktop/sare backup/c/user hadar/Desktop/GEO511/Tasks/geo511-tasks-hsare/geo511-2020-final-project/geo511-2020-project-hsare/visualize_of_landingMining_sites/Mars_Viking_MDIM21_ClrMosaic_global_1024.jpg", bodycolor="#555555", emissive="#444444",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my main comment. This raster is located on your personal machine, preventing myself or anyone else from running the code. It renders the rest of your code and analysis unable to run as well.

coconn41
coconn41 commented Nov 19, 2020
View reviewed changes
index.Rmd
@@ -261,23 +262,18 @@ as(MNDWI, "SpatialPixelsDataFrame") %>%

I loaded required packages

```{r, message=F, warning=F}
library(threejs)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best practice: List all libraries at the beginning of code. See comment in your original libraries calls.

coconn41
coconn41 commented Nov 19, 2020
View reviewed changes
index.Rmd

##Results2
I firstly prepared and loaded the data and then with the package called "streejs" I plot the exact locations of landing and mining sites on the Martian global map. I created a cvs file where I stored the latitudes and logitude of the future landing and mining sites selested and call that file in R.


```{r}
library(threejs)
library(csvread)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best practice: List all libraries at the beginning of code. See comment in your original libraries calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@coconn41