Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort downloads in proper alphabetical order #47

Merged
merged 4 commits into from
Aug 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
name: Lint, test and publish

on: ["push"]

jobs:

lint:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
- uses: actions/setup-python@v1
with:
python-version: 3.8
- name: Install Flake8
run: |
pip install flake8
- name: Flake8
run: flake8 --ignore=E501,W504 biomaj_download/*.py biomaj_download/download

test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v1
with:
python-version: 3.8
- name: Install requirements
run: |
sudo apt update
sudo apt install libcurl4-openssl-dev libssl-dev
pip install pytest
python setup.py install
- name: Run tests
run: |
LOCAL_IRODS=0 NETWORK=0 pytest -v tests/biomaj_tests.py

pypi:
runs-on: ubuntu-latest
needs: [lint, test]
name: Deploy release to Pypi
steps:
- name: Checkout
uses: actions/checkout@v4
- uses: actions/setup-python@v1
with:
python-version: 3.8
- name: Python install
run: pip install -U pip setuptools build
- name: Build a binary wheel and a source tarball
run: python -m build --sdist --wheel --outdir dist/ .
- name: Publish distribution 📦 to PyPI
if: github.event_name == 'push' && startsWith(github.event.ref, 'refs/tags')
uses: pypa/gh-action-pypi-publish@master
with:
password: ${{ secrets.pypi_password }}
35 changes: 0 additions & 35 deletions .travis.yml

This file was deleted.

3 changes: 3 additions & 0 deletions CHANGES.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
3.2.12:
Sort downloads in proper alphabetical order

3.2.11:
fix direct handler in case of plugin usage

Expand Down
2 changes: 1 addition & 1 deletion biomaj_download/downloadclient.py
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ def wait_for_download(self):
for i in range(max_submit):
if self.download_pool:
logging.debug('Workflow:wf_download:RemoteDownload:RequestNewFile')
operation = self.download_pool.pop()
operation = self.download_pool.pop(0)
self.ask_download(operation)
nb_submitted += 1

Expand Down
2 changes: 0 additions & 2 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
pytest
pycurl
py-bcrypt
pika==0.13.0
Expand All @@ -11,7 +10,6 @@ prometheus_client>=0.0.18
requests
biomaj_core>=3.0.19
biomaj_zipkin
flake8
humanfriendly
python-irodsclient
simpleeval
Expand Down
6 changes: 6 additions & 0 deletions setup.cfg
Original file line number Diff line number Diff line change
@@ -1,2 +1,8 @@
[bdist_wheel]
universal=1

[metadata]
description-file = README.md

[flake8]
ignore = E501,W504
10 changes: 5 additions & 5 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@
'description': 'BioMAJ download service',
'long_description': README + '\n\n' + CHANGES,
'long_description_content_type': 'text/markdown',
'author': 'Olivier Sallou',
'url': 'http://biomaj.genouest.org',
'download_url': 'http://biomaj.genouest.org',
'author_email': '[email protected]',
'version': '3.2.11',
'author': 'GenOuest platform',
'url': 'https://biomaj.genouest.org',
'download_url': 'https://biomaj.genouest.org',
'author_email': '[email protected]',
'version': '3.2.12',
'classifiers': [
# How mature is this project? Common values are
# 3 - Alpha
Expand Down
Loading