Skip to content

Commit

Permalink
some linting
Browse files Browse the repository at this point in the history
  • Loading branch information
@abretaud
abretaud committed Nov 24, 2023
1 parent 520ff59 commit 72a7cdf
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 5 deletions.
3 changes: 3 additions & 0 deletions .hadolint.yaml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
ignored:
- DL3008
- DL3003
15 changes: 10 additions & 5 deletions Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@ ENV prometheus_multiproc_dir=/tmp/biomaj-prometheus-multiproc
RUN rm -rf /tmp/biomaj-prometheus-multiproc && \
mkdir -p /tmp/biomaj-prometheus-multiproc

RUN apt-get update && apt-get install -y apt-transport-https curl libcurl4-openssl-dev python3-pycurl python3-setuptools python3-pip git unzip bzip2 ca-certificates jq --no-install-recommends
RUN apt-get update \
&& apt-get install -y apt-transport-https curl libcurl4-openssl-dev python3-pycurl python3-setuptools python3-pip git unzip bzip2 ca-certificates jq --no-install-recommends \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*

# Install docker to allow docker execution from process-message
RUN buildDeps='gnupg2 dirmngr software-properties-common' \

Check failure on line 16 in Dockerfile

View workflow job for this annotation

GitHub Actions / lint 

DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check

Check failure on line 16 in Dockerfile

View workflow job for this annotation

GitHub Actions / lint 

DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
Expand All @@ -17,7 +20,9 @@ RUN buildDeps='gnupg2 dirmngr software-properties-common' \
&& add-apt-repository "deb [arch=amd64] https://download.docker.com/linux/debian $(lsb_release -cs) stable" \
&& apt-get update \
&& apt-get install --no-install-recommends -y docker-ce-cli \
&& apt-get purge -y --auto-remove "$buildDeps"
&& apt-get purge -y --auto-remove "$buildDeps" \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*

ENV BIOMAJ_RELEASE="shahikorma-v13"

Expand All @@ -38,7 +43,7 @@ ENV BIOMAJ_CONFIG=/etc/biomaj/config.yml

RUN mkdir -p /var/log/biomaj

RUN pip3 install setuptools --upgrade && \
RUN pip3 install --no-cache-dir setuptools --upgrade && \

Check failure on line 46 in Dockerfile

View workflow job for this annotation

GitHub Actions / lint 

DL3013 warning: Pin versions in pip. Instead of `pip install <package>` use `pip install <package>==<version>` or `pip install --requirement <requirements file>`

Check failure on line 46 in Dockerfile

View workflow job for this annotation

GitHub Actions / lint 

DL3013 warning: Pin versions in pip. Instead of `pip install <package>` use `pip install <package>==<version>` or `pip install --requirement <requirements file>`
pip3 install --no-cache-dir greenlet==0.4.17 && \
pip3 install --no-cache-dir gevent==1.4.0 && \
pip3 install --no-cache-dir graypy && \
Expand Down Expand Up @@ -66,9 +71,9 @@ RUN buildDeps="gcc python3-dev protobuf-compiler" \
&& cd /root/biomaj-release && python3 setup.py build && pip3 install --no-cache-dir . \
&& cd /root/biomaj-data && python3 setup.py build && pip3 install --no-cache-dir . \
&& apt-get install --no-install-recommends -y wget bzip2 ca-certificates curl git \
&& apt-get purge -y --auto-remove "$buildDeps" \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/* \
&& apt-get purge -y --auto-remove "$buildDeps"
&& rm -rf /var/lib/apt/lists/*



Expand Down

0 comments on commit 72a7cdf

Please sign in to comment.