Fix wrong input proteins management #37
Open
+181
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue described in #35, related to how Binette handles proteins given as inputs.
Currently, Binette excludes unbinned contigs to avoid unnecessary computations (e.g., running Prodigal and Diamond on unused contigs). While this saves time, it creates a mismatch when protein files are provided, as unbinned contigs are still present in the protein data. This inconsistency triggers errors during the step that checks for differences between the assembly contigs and the proteins.
Solution
Filtered Protein File
<outdir>/temporary_files/
and passed to Diamond for gene annotation.Additional changes
Temporary File Compression
<outdir>/temporary_files/
, including the FAA file and Diamond results, are now compressed to save disk space.-The pyfastx index for the contig file is now stored in /temporary_files/ instead of alongside the assembly file. This ensures files are written only to the intended directory, avoiding unwanted file placements.