This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
consolidate with and with-out template database creation #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nnutter
commented
Nov 12, 2014
nnutter
commented
- consolidate with and with-out template database creation (closes Consolidate CreateDatabase and CreateDatabaseFromTemplate #20)
- allow owner to be overridden when creating a database from a template (partial Add option to override owner #24)
- fix issue preventing databases from being created with owners due to role permissions
"Since this catalog (pg_authid) contains passwords, it must not be publicly readable. pg_roles is a publicly readable view on pg_authid that blanks out the password field."
Automatically grant roles to the superuser so that it can create new databases with that owner.
For this test to pass it is required that `test_db_user` and `db_user` are never the same. `new_pg_instance()` used `test_db_user` as the default owner so this will try to override that owner with `db_user`.
|
+1 after tests pass |
nnutter
added a commit
that referenced
this pull request
Nov 13, 2014
consolidate with and with-out template database creation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.