Add support for iOS 8+, and fix UI using auto layout #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to support at least 8.0, fixed deprecated UIActionSheet with UIAlertController for both places showing action sheet menu selection; * Taking photo or import from gallery * Rotate image in crop screen
Added back the original implementation of GKImagePicker regarding to UIActionSheet in both GKImagePicker, and GKImageCropper class. Changed presentPicker method signature to presentPickerFrom: to explicitly accept UIViewController from where it will present picker view controller. Also added deprecated macro for presentPickerFrom: method as it originally has supported since iOS 6.0.
Added launchscreens to let iPhone be able to detect a proper screen size.
Also fixed showing image in UIImageView with aspect fit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About deprecations
Use
UIAlertControllerclass instead ofUIActionSheetwhen possible.Added above with remain backward compatibility as original. For the case of
GKImagePickerto show action sheet, provided with 2 methods to choose from which arepresentPickerFrom:(UIViewController*)viewControllerpresentPickerWithAnchor:(UIView*)anchor from:(UIViewController*)viewControllerAlso fixed calling deprecated method from old API i.e.
presentModalViewController, anddismissModalViewControllerAnimated:In case of
GKImageCropper, provided with run-time checking whetherUIAlertControlleris available, thus use it or otherwise useUIActionSheet.About more support, and UI fixes
Fixed layout to be consistent across all devices screen via auto layout. Also changed
UIImageView's content mode to be aspect fit. Added launch screens for all portrait orientation. The latter is to let devices detect the proper and correct screen size.