Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up unified tests #337

Merged
merged 6 commits into from
Sep 6, 2024

Conversation

euonymos
Copy link
Contributor

@euonymos euonymos commented Aug 25, 2024

Summary

The way tests were organized was very messy. No clean separation, use of higher monad than needed, and so on. The docs were updated accordingly in this PR

Type of Change

Please mark the relevant option(s) for your pull request:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring (improving code quality without changing its behavior)
  • Documentation update (adding or updating documentation related to the project)

Checklist

Please ensure that your pull request meets the following criteria:

  • I have read the Contributing Guide
  • My code follows the project's coding style and best practices
  • My code is appropriately commented and includes relevant documentation
  • I have added tests to cover my changes
  • All new and existing tests pass
  • I have updated the documentation, if necessary

@euonymos euonymos force-pushed the euonymos/clean-unified-tests branch from 5d8f7ed to 15078db Compare August 25, 2024 21:08
@sourabhxyz
Copy link
Member

@euonymos Could you rebase it? Thanks!

Copy link
Member

@sourabhxyz sourabhxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @euonymos, PR LGTM.

@4TT1L4 4TT1L4 merged commit 1e6ea97 into geniusyield:main Sep 6, 2024
1 of 2 checks passed
@euonymos
Copy link
Contributor Author

Ups I didn't check all tests, ok, let me do it now just to be sure. Also I think I dropped fourmolu somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants