Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Reset and FactoryReset #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

takimp
Copy link

@takimp takimp commented Dec 17, 2021

Fixes :

  1. Send 0 BOOTSTRAP when script is executed.
  2. Child's parameters are not created for the 1st object.

Additional :

  1. Reboot
  2. FactoryReset

@pedrojreis
Copy link

@zaidka think we can also merge this? Super useful to have the ability to Reboot & FR on simulators

@zaidka
Copy link
Member

zaidka commented Sep 26, 2024

I hate to be blunt, but the commented out test code, the various formatting issues and unnecessary changes don't inspire confidence. I understand you've probably tested it and confirmed it works for you, but I take a clean but broken solution over a messy but working one any day. If you can clean it up and make sure you're not making more changes than really necessary, I'd be happy to take another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants