Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cache for datastructures of the user/permission management #89

Merged
merged 1 commit into from
Nov 8, 2018

Conversation

okraits
Copy link
Contributor

@okraits okraits commented Dec 6, 2017

This PR utilizes the rails cache to store the datastructures of the user/permission management of GenieACS GUI. The cache is cleared if there was a change related to users, roles or permissions.

@okraits okraits force-pushed the tdt-master-caching branch from 09ba90a to c04ad95 Compare December 7, 2017 07:59
@okraits
Copy link
Contributor Author

okraits commented Jan 10, 2018

@zaidka Any opinion about this?

@okraits
Copy link
Contributor Author

okraits commented Nov 7, 2018

@zaidka No interest in improving the GUI?

@akcoder
Copy link
Contributor

akcoder commented Nov 7, 2018 via email

@okraits
Copy link
Contributor Author

okraits commented Nov 8, 2018

@akcoder Does it take so long to write a short reply? No reply in almost a year doesn't look like much interest.

@akcoder
Copy link
Contributor

akcoder commented Nov 8, 2018 via email

@zaidka zaidka merged commit e96da6d into genieacs:master Nov 8, 2018
@okraits
Copy link
Contributor Author

okraits commented Nov 8, 2018

@zaidka Wow, that was an answer 😀 Thank you!

I have another improvement for this "feature" in the pipeline. Will create a PR tomorrow.

@okraits okraits deleted the tdt-master-caching branch November 8, 2018 22:10
@zaidka
Copy link
Member

zaidka commented Nov 8, 2018

I'm sorry :( Been very busy and overwhelmed with development and support. I keep postponing things until they get buried and I forget about them.

I have merged this now.

There's a few interesting things that I have been working on in hiding for the past year. Of which is a complete rewrite of the UI and a new API and query language to go with that. Will be sharing more details soon-ish.

Sorry again for not being very responsive. And thanks for the PR.

@okraits
Copy link
Contributor Author

okraits commented Nov 9, 2018

No problem! Slight but important improvement submitted in #102.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants