Add Step 1 log to report #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the log from Step 1 is not reported in the output report.html file, even if step 1 was performed and the step1.log file exists in the output directory; the html always shows 'Regenie step 1 skipped' under the Regenie Step 1 Log section. My suggested changes address this bug so that the Regenie Step 1 Log is reported if step 1 was run.
Additionally, I checked that if 'regenie_skip_predictions = true' in the config, Step 1 is correctly reported as 'Regenie step 1 skipped' with these modifications.