Skip to content

Commit

Permalink
fix: Fix ResourceID field optional tag format
Browse files Browse the repository at this point in the history
  • Loading branch information
jasonvigil committed Oct 1, 2024
1 parent a41e488 commit d75ce11
Show file tree
Hide file tree
Showing 12 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion apis/bigquery/v1beta1/bigquerydataset_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ var BigQueryDatasetGVK = GroupVersion.WithKind("BigQueryDataset")
// +kcc:proto=google.cloud.bigquery.v2.dataset
type BigQueryDatasetSpec struct {
// The BigQueryDataset name. If not given, the metadata.name will be used.
// + optional
// +optional
ResourceID *string `json:"resourceID,omitempty"`

// An array of objects that define dataset access for one or more entities.
Expand Down
2 changes: 1 addition & 1 deletion apis/bigqueryconnection/v1alpha1/connection_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ type BigQueryConnectionConnectionSpec struct {

// The BigQuery ConnectionID. This is a server-generated ID in the UUID format.
// If not provided, ConfigConnector will create a new Connection and store the UUID in `status.serviceGeneratedID` field.
// + optional
// +optional
ResourceID *string `json:"resourceID,omitempty"`

// User provided display name for the connection.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ type BigQueryDataTransferConfigSpec struct {
// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="ResourceID field is immutable"
// Immutable.
// The BigQueryDataTransferConfig name. If not given, the metadata.name will be used.
// + optional
// +optional
ResourceID *string `json:"resourceID,omitempty"`

// Data transfer schedule.
Expand Down
2 changes: 1 addition & 1 deletion apis/bigtable/v1beta1/bigtableinstance_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ var (
// +kcc:proto=google.bigtable.admin.v2.Instance
type BigtableInstanceSpec struct {
// The Instance name. If not given, the metadata.name will be used.
// + optional
// +optional
ResourceID *string `json:"resourceID,omitempty"`

// // The unique name of the instance. Values are of the form
Expand Down
2 changes: 1 addition & 1 deletion apis/cloudbuild/v1beta1/workerpool_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ type CloudBuildWorkerPoolSpec struct {
DisplayName string `json:"displayName,omitempty"`

// The `WorkerPool` name. If not given, the metadata.name will be used.
// + optional
// +optional
ResourceID *string `json:"resourceID,omitempty"`

// +required
Expand Down
2 changes: 1 addition & 1 deletion apis/firestore/v1alpha1/firestoredatabase_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ type FirestoreDatabaseSpec struct {
ProjectRef v1beta1.ProjectRef `json:"projectRef"`

// The FirestoreDatabase name. If not given, the metadata.name will be used.
// + optional
// +optional
ResourceID *string `json:"resourceID,omitempty"`

// The location of the database. Available locations are listed at
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ type NetworkConnectivityServiceConnectionPolicySpec struct {
Location *string `json:"location"`

// The NetworkConnectivityServiceConnectionPolicy name. If not given, the metadata.name will be used.
// + optional
// +optional
ResourceID *string `json:"resourceID,omitempty"`

// A description of this resource.
Expand Down
2 changes: 1 addition & 1 deletion apis/redis/v1alpha1/rediscluster_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ type RedisClusterSpec struct {
Location *string `json:"location"`

// The RedisCluster name. If not given, the metadata.name will be used.
// + optional
// +optional
ResourceID *string `json:"resourceID,omitempty"`

// Optional. The authorization mode of the Redis cluster.
Expand Down
2 changes: 1 addition & 1 deletion apis/secretmanager/v1beta1/secretmanagersecret_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ type SecretManagerSecretSpec struct {
// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="ResourceID field is immutable"
// Immutable.
// The SecretManagerSecret name. If not given, the metadata.name will be used.
// + optional
// +optional
ResourceID *string `json:"resourceID,omitempty"`

// Optional. Immutable. The replication policy of the secret data attached to
Expand Down
2 changes: 1 addition & 1 deletion apis/workstations/v1alpha1/workstationcluster_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ type WorkstationClusterSpec struct {
// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="ResourceID field is immutable"
// Immutable.
// The WorkstationCluster name. If not given, the metadata.name will be used.
// + optional
// +optional
ResourceID *string `json:"resourceID,omitempty"`

// Optional. Human-readable name for this workstation cluster.
Expand Down
2 changes: 1 addition & 1 deletion dev/tools/controllerbuilder/template/apis/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ type {{ .Kind }}Spec struct {
// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="ResourceID field is immutable"
// Immutable.
// The {{ .Kind }} name. If not given, the metadata.name will be used.
// + optional
// +optional
ResourceID *string ` + "`" + `json:"resourceID,omitempty"` + "`" + `
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/apis/common/v1alpha1/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import (

type CommonSpec struct {
// The GCP resource identifier. If not given, the metadata.name will be used.
// + optional
// +optional
ResourceID *string `json:"resourceID,omitempty"`

// TODO: Do we still need a CommonSpec for resources that do not need project dependency? Those seems to be exceptional any ways.
Expand Down

0 comments on commit d75ce11

Please sign in to comment.