Skip to content

Commit

Permalink
Merge pull request GoogleCloudPlatform#2262 from gemmahou/normalize-id
Browse files Browse the repository at this point in the history
minor fix: normalized ID should be integer
  • Loading branch information
google-oss-prow[bot] authored Jul 11, 2024
2 parents 9140424 + 2241825 commit abdfee8
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,6 @@ status:
type: Ready
observedGeneration: 1
observedState:
certificateID: "1.719337333063698e+18"
certificateID: 1111111111111111
creationTimestamp: "1970-01-01T00:00:00Z"
selfLink: https://compute.googleapis.com/compute/v1/projects/${projectId}/global/sslCertificates/computemanagedsslcertificate-${uniqueId}
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@ status:
status: "True"
type: Ready
creationTimestamp: "1970-01-01T00:00:00Z"
gatewayId: "1.719337333063698e+18"
gatewayId: 1111111111111111
observedGeneration: 2
selfLink: https://compute.googleapis.com/compute/v1/projects/${projectId}/regions/us-central1/targetVpnGateways/computevpngateway-${uniqueId}
4 changes: 2 additions & 2 deletions tests/e2e/normalize.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,9 @@ func normalizeKRMObject(u *unstructured.Unstructured, project testgcp.GCPProject
visitor.replacePaths[".status.observedState.softDeletePolicy.effectiveTime"] = "1970-01-01T00:00:00Z"

// Specific to Compute
visitor.replacePaths[".status.observedState.certificateID"] = "1.719337333063698e+18"
visitor.replacePaths[".status.observedState.certificateID"] = 1111111111111111
visitor.replacePaths[".status.instanceId"] = "1111111111111111"
visitor.replacePaths[".status.gatewayId"] = "1.719337333063698e+18"
visitor.replacePaths[".status.gatewayId"] = 1111111111111111

// Specific to MonitoringDashboard
visitor.stringTransforms = append(visitor.stringTransforms, func(path string, s string) string {
Expand Down

0 comments on commit abdfee8

Please sign in to comment.