Remove networkTier for global forwarding rule

gemmahou · Sep 18, 2024 · 9e831e6 · 9e831e6
1 parent 6afeab4
commit 9e831e6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/pkg/controller/direct/compute/forwardingrule_controller.go b/pkg/controller/direct/compute/forwardingrule_controller.go
@@ -318,6 +318,11 @@ func (a *forwardingRuleAdapter) Create(ctx context.Context, createOp *directbase
 	var err error
 	op := &gcp.Operation{}
 	if a.id.location == "global" {
+		// todo(yuhou): TF does not support networkTier field for global forwarding rule
+		// It will always use GCP's default value, which is "PREMIUM." Any value set by the user will be ignored and not sent to GCP.
+		// To align with the TF controller, I remove this field.
+		// Ideally, direct controller should support this field and validate that the value.
+		forwardingRule.NetworkTier = nil
 		req := &computepb.InsertGlobalForwardingRuleRequest{
 			ForwardingRuleResource: forwardingRule,
 			Project:                a.id.project,

diff --git a/...ata/basic/compute/v1beta1/computeforwardingrule/globalcomputeforwardingrulefull/_http.log b/...ata/basic/compute/v1beta1/computeforwardingrule/globalcomputeforwardingrulefull/_http.log
@@ -770,7 +770,6 @@ x-goog-request-params: project=${projectId}
   ],
   "name": "computeglobalforwardingrule-${uniqueId}",
   "network": "projects/${projectId}/global/networks/${networkID}",
-  "networkTier": "PREMIUM",
   "portRange": "80",
   "target": "https://www.googleapis.com/compute/v1/projects/${projectId}/global/targetHttpProxies/computetargethttpproxy-${uniqueId}"
 }