turn on ComputeTCPProxy direct controller

apis/compute/v1beta1/targettcpproxy_types.go

@@ -87,7 +87,7 @@ type ComputeTargetTCPProxyObservedState struct {
 // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
 // +kubebuilder:resource:categories=gcp,shortName=gcpcomputetargettcpproxy;gcpcomputetargettcpproxies
 // +kubebuilder:subresource:status
-// +kubebuilder:metadata:labels="cnrm.cloud.google.com/tf2crd=true";"cnrm.cloud.google.com/stability-level=stable";"cnrm.cloud.google.com/managed-by-kcc=true";"cnrm.cloud.google.com/system=true"
+// +kubebuilder:metadata:labels="cnrm.cloud.google.com/stability-level=stable";"cnrm.cloud.google.com/managed-by-kcc=true";"cnrm.cloud.google.com/system=true"
 // +kubebuilder:printcolumn:name="Age",JSONPath=".metadata.creationTimestamp",type="date"
 // +kubebuilder:printcolumn:name="Ready",JSONPath=".status.conditions[?(@.type=='Ready')].status",type="string",description="When 'True', the most recent reconcile of the resource succeeded"
 // +kubebuilder:printcolumn:name="Status",JSONPath=".status.conditions[?(@.type=='Ready')].reason",type="string",description="The reason for the value in 'Ready'"

config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_computetargettcpproxies.compute.cnrm.cloud.google.com.yaml

@@ -8,7 +8,6 @@ metadata:
     cnrm.cloud.google.com/managed-by-kcc: "true"
     cnrm.cloud.google.com/stability-level: stable
     cnrm.cloud.google.com/system: "true"
-    cnrm.cloud.google.com/tf2crd: "true"
   name: computetargettcpproxies.compute.cnrm.cloud.google.com
 spec:
   group: compute.cnrm.cloud.google.com

config/samples/resources/computetargettcpproxy/compute_v1beta1_computetargettcpproxy.yaml → config/samples/resources/computetargettcpproxy/global-target-tcp-proxy/compute_v1beta1_computetargettcpproxy.yaml

@@ -17,6 +17,6 @@ kind: ComputeTargetTCPProxy
 metadata:
   name: computetargettcpproxy-sample
 spec:
-  description: "A sample TCP proxy."
+  description: "A sample global TCP proxy."
   backendServiceRef:
-    name: computetargettcpproxy-dep
+    name: computebackendservice-2-${uniqueId}

pkg/test/resourcefixture/testdata/basic/compute/v1beta1/computeforwardingrule/globalcomputeforwardingruletcp/update.yaml → config/samples/resources/computetargettcpproxy/regional-target-tcp-proxy/compute_v1beta1_computebackendservice.yaml

@@ -1,10 +1,10 @@
-# Copyright 2022 Google LLC
+# Copyright 2024 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at
 #
-#      http://www.apache.org/licenses/LICENSE-2.0
+#     http://www.apache.org/licenses/LICENSE-2.0
 #
 # Unless required by applicable law or agreed to in writing, software
 # distributed under the License is distributed on an "AS IS" BASIS,
@@ -13,20 +13,16 @@
 # limitations under the License.
 
 apiVersion: compute.cnrm.cloud.google.com/v1beta1
-kind: ComputeForwardingRule
+kind: ComputeBackendService
 metadata:
-  labels:
-    label-one: "value-two"
-  name: computeglobalforwardingrule-${uniqueId}
+  name: computetargettcpproxy-dep
 spec:
-  description: "A global forwarding rule"
-  location: global
-  target:
-    targetTCPProxyRef:
-      name: computetargettcpproxy2-${uniqueId}
-  portRange: "110"
-  ipProtocol: "TCP"
-  loadBalancingScheme: EXTERNAL
-  ipAddress:
-    addressRef:
-      name: computeaddress-${uniqueId}
+  healthChecks:
+    - healthCheckRef:
+        name: computetargettcpproxy-dep
+  location: europe-west4
+  protocol: TCP
+  # Default loadBalancingScheme for regional backend service is INTERNAL
+  # Set to INTERNAL_MANAGED when being referenced by Regional Target TCP Proxy
+  # googleapi error: Regional Target TCP Proxy cannot be used with BackendServices with schema INTERNAL
+  loadBalancingScheme: INTERNAL_MANAGED

pkg/test/resourcefixture/testdata/basic/compute/v1beta1/computetargettcpproxy/globalcomputetargettcpproxy-basic/create.yaml → config/samples/resources/computetargettcpproxy/regional-target-tcp-proxy/compute_v1beta1_computehealthcheck.yaml

@@ -1,10 +1,10 @@
-# Copyright 2022 Google LLC
+# Copyright 2024 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at
 #
-#      http://www.apache.org/licenses/LICENSE-2.0
+#     http://www.apache.org/licenses/LICENSE-2.0
 #
 # Unless required by applicable law or agreed to in writing, software
 # distributed under the License is distributed on an "AS IS" BASIS,
@@ -13,11 +13,11 @@
 # limitations under the License.
 
 apiVersion: compute.cnrm.cloud.google.com/v1beta1
-kind: ComputeTargetTCPProxy
+kind: ComputeHealthCheck
 metadata:
-  annotations:
-    cnrm.cloud.google.com/project-id: ${projectId}
-  name: computetargettcpproxy-${uniqueId}
+  name: computetargettcpproxy-dep
 spec:
-  backendServiceRef:
-    name: computebackendservice-${uniqueId}
+  checkIntervalSec: 10
+  tcpHealthCheck:
+    port: 443
+  location: europe-west4

pkg/test/resourcefixture/testdata/basic/compute/v1beta1/computetargettcpproxy/globalcomputetargettcpproxy-full/create.yaml → config/samples/resources/computetargettcpproxy/regional-target-tcp-proxy/compute_v1beta1_computetargettcpproxy.yaml

@@ -1,10 +1,10 @@
-# Copyright 2022 Google LLC
+# Copyright 2024 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at
 #
-#      http://www.apache.org/licenses/LICENSE-2.0
+#     http://www.apache.org/licenses/LICENSE-2.0
 #
 # Unless required by applicable law or agreed to in writing, software
 # distributed under the License is distributed on an "AS IS" BASIS,
@@ -15,12 +15,11 @@
 apiVersion: compute.cnrm.cloud.google.com/v1beta1
 kind: ComputeTargetTCPProxy
 metadata:
-  annotations:
-    cnrm.cloud.google.com/project-id: ${projectId}
-  name: computetargettcpproxy-${uniqueId}
+  name: computetargettcpproxy-sample
 spec:
-  description: "test target tcp proxy"
+  description: "A sample regional TCP proxy."
   backendServiceRef:
-    name: computebackendservice-${uniqueId}
+    name: computetargettcpproxy-dep
   proxyBind: false
   proxyHeader: NONE
+  location: europe-west4

pkg/snippet/snippetgeneration/snippetgeneration.go

@@ -68,6 +68,7 @@ var preferredSampleForResource = map[string]string{
 	"computesslcertificate":              "global-compute-ssl-certificate",
 	"computesslpolicy":                   "modern-tls-1-1-ssl-policy",
 	"computetargethttpsproxy":            "target-https-proxy-with-ssl-certificates",
+	"computetargettcpproxy":              "global-target-tcp-proxy",
 	"computeurlmap":                      "global-compute-url-map",
 	"configcontrollerinstance":           "autopilot-config-controller-instance",
 	"containerattachedcluster":           "container-attached-cluster-basic",

pkg/test/resourcefixture/testdata/basic/compute/v1beta1/computeforwardingrule/globalcomputeforwardingruletcp-direct/dependencies.yaml

@@ -46,7 +46,6 @@ kind: ComputeTargetTCPProxy
 metadata:
   annotations:
     cnrm.cloud.google.com/project-id: ${projectId}
-    alpha.cnrm.cloud.google.com/reconciler: "direct"
   name: computetargettcpproxy-${uniqueId}
 spec:
   description: "test description"
@@ -59,7 +58,6 @@ kind: ComputeTargetTCPProxy
 metadata:
   annotations:
     cnrm.cloud.google.com/project-id: ${projectId}
-    alpha.cnrm.cloud.google.com/reconciler: "direct"
   name: computetargettcpproxy2-${uniqueId}
 spec:
   description: "other test description"