Fix types #1038
Merged
Fix types #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DudaGod
commented
Dec 2, 2024
| @@ -128,8 +128,94 @@ export interface ExpectOptsConfig { | |||
| interval: number; | |||
| } | |||
|
|
|||
| export interface MochaOpts extends Omit<Mocha.MochaOptions, "ui"> { | |||
There was a problem hiding this comment.
Remove Mocha.MochaOptions in order to not get conflicts in it, describe etc. Reproduced when service has @types/mocha module (can be installed as dependencies from some other module).
| @@ -260,9 +346,13 @@ export interface SetsConfigParsed { | |||
| browsers: Array<string>; | |||
| } | |||
|
|
|||
| type PartialCommonConfig = Partial<Omit<CommonConfig, "system">> & { | |||
| system?: Partial<SystemConfig>; | |||
There was a problem hiding this comment.
Field system should not require specifying all fields
shadowusr
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.