fix: correctly specify types for "mochaOpts" and "patternsOnReject" #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DudaGod
commented
Nov 27, 2024
| } | ||
|
|
||
| export interface SystemConfig { | ||
| debug: boolean; | ||
| mochaOpts: MochaOpts; | ||
| expectOpts: ExpectOptsConfig; | ||
| ctx: { [name: string]: unknown }; | ||
| patternsOnReject: Array<string>; | ||
| patternsOnReject: Array<string | RegExp>; |
There was a problem hiding this comment.
It can be specified as RegExp. Like this:
patternsOnReject: [/foo/i, /bar/, /baz/g]
Under the hood we wrap all items from patternsOnReject to RegExp. Like this - new RegExp(pattern). So it works correctly if user specify regexp value.
| timeout?: number; | ||
|
|
||
| /** string or regexp to filter tests with. */ | ||
| grep?: string | RegExp; |
There was a problem hiding this comment.
All these options specified inside Mocha.MochaOptions, so I just use it. Moreover it has a lot of other options that user can use.
| /** string or regexp to filter tests with. */ | ||
| grep?: string | RegExp; | ||
| export interface MochaOpts extends Omit<Mocha.MochaOptions, "ui"> { | ||
| ui?: string | ((suite: Mocha.Suite) => void); |
There was a problem hiding this comment.
Currently ui field inside mocha specified incorrectly. It says that I can use only: bdd, tdd and other prepared interfaces. But actually I can specify just a string to the file which will be required by mocha or use function
KuznetsovRoman
approved these changes
Nov 27, 2024
DudaGod
force-pushed
the
TESTPLANE-351.fix_types
branch
from
747083a
to
6cfb9e1
Compare
Dannymex420
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.