fix: stop REPL servers on call "halt" method #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DudaGod
force-pushed
the
TESTPLANE-251.close_repl_on_halt
branch
from
06c4f57
to
aeb19e8
Compare
DudaGod
commented
Sep 19, 2024
| @@ -8,3 +8,7 @@ testplaneFacade.init(); | |||
| exports.runTest = (fullTitle, options) => { | |||
| return testplaneFacade.runTest(fullTitle, options); | |||
| }; | |||
|
|
|||
| exports.cancel = () => { | |||
There was a problem hiding this comment.
I can't stop repl server from master process. So I need to send command to all workers.
| @@ -31,6 +31,10 @@ module.exports = class TestplaneFacade { | |||
| return this.promise; | |||
| } | |||
|
|
|||
| cancel(): void { | |||
| RuntimeConfig.getInstance().replServer?.close(); | |||
There was a problem hiding this comment.
If replServer doesn't exist (user do not use --repl option) then nothing will fail here.
sipayRT
approved these changes
Sep 19, 2024
DudaGod
force-pushed
the
TESTPLANE-251.close_repl_on_halt
branch
from
aeb19e8
to
a527042
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is done
In the case when the user switches to REPL mode and then someone calls
haltmethod, then Testplane does not end correctly. In this case, it is necessary to explicitly close the repl server in worker. So I did it.