Add guide alarms endpoint #12
Conversation
| }); | ||
|
|
||
| // Convert the array of alarms to an object with the wfs as the key | ||
| return Object.fromEntries(alarms.map((alarm) => [alarm.wfs, alarm])) as Record<WfsType, GuideAlarm>; |
There was a problem hiding this comment.
I have the confusion, I have read different opinions about having "variable" key objects against having arrays of objects with a specific key with value equals to the variable.
I like your approach and maybe you can enlighten me about this.
There was a problem hiding this comment.
Yeah, there's something to be said for either approach. In this case, I chose for it because there's a very limited number of values, and the values should always exist. In an array, there's no certainty that a value will exist because you have to iterate over the array. This way, if it doesn't things will break early
There was a problem hiding this comment.
Anyway, we are lucky that GN and GS use the same wavefront sensors, then those names should not change, even after the desired wfs upgrade.
|
LGTM! |
Related: gemini-hlsw/navigate-ui#22