improve group events

[tpolecat]

This changes the group event stream to trigger when the contents of a group change, so you get an event when an observation is created, and two events when an observation is moved.

[tpolecat]

@hugo-vrijswijk maybe you can say a few words about how you intend to consume this event. We could add more information (like a CONTENTS_CHANGED event type for instance) but I'm not sure what you need.

[codecov-commenter]

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (ffb5f09) 78.94% compared to head (ba53731) 79.39%.
Report is 17 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #787      +/-   ##
==========================================
+ Coverage   78.94%   79.39%   +0.44%     
==========================================
  Files         525      532       +7     
  Lines        9067    11529    +2462     
  Branches       26       27       +1     
==========================================
+ Hits         7158     9153    +1995     
- Misses       1909     2376     +467     

Files	Coverage Δ
...cala/lucuma/odb/graphql/input/GroupEditInput.scala	100.00% <ø> (ø)
.../lucuma/odb/graphql/mapping/GroupEditMapping.scala	100.00% <100.00%> (ø)
...ma/odb/graphql/predicate/GroupEditPredicates.scala	100.00% <ø> (ø)
...in/scala/lucuma/odb/graphql/topic/GroupTopic.scala	77.41% <66.66%> (ø)
...a/lucuma/odb/graphql/predicate/LeafPredicate.scala	54.54% <0.00%> (-20.46%)	⬇️
...cuma/odb/graphql/mapping/SubscriptionMapping.scala	65.09% <85.71%> (+11.76%)	⬆️

... and 46 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[swalker2m]

This looks good / makes sense to me. Is it still a WIP?

[tpolecat]

It's ready, assuming it does what Hugo needs. I want to double-check with him before merging.

[hugo-vrijswijk]

I think this is good. Ideally there would be three events (or 2 when moved inside the same group)

• groupEdit if a group is moved (with parentGroupId and/or parentGroupIndex changed) (already fired, I think)
• observationEdit when an obs is moved (with groupId and/or groupIndex changed) (already fired, I think)

And for the old/new groups

• groupEdit for the new group (with new elements)
• groupEdit for the old group (with changed elements
  With this being a single event if an element is moved inside the same group.

For the root group it works if there is no event for the root group, only for the new group (and for elements in the root group being moved/updated). I.e:

1. Obs is moved outside of root group
2. observationEdit event with a new groupId (already works)
3. groupEdit event for the group the obs is moved to
4. observationEdit with groupIndex updated for the elements in the root group (already works, I think)

[hugo-vrijswijk]

I don't think this has to be nullable. If the root group is updated it's fine if just the elements inside it are updated (with a new index)

[tpolecat]

I think for consistency it needs to be nullable, but you can ignore this case on your end if you like.

[tpolecat]

Ok I guess let's merge this and see how it goes. We can continue to tweak it depending on what Hugo runs into.

[tpolecat]

Need an amen from someone.

[swalker2m]

Amen.