Grackle 0.14 #710
Merged
Grackle 0.14 #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpolecat
force-pushed
the
update-grackle
branch
from
69ba7d7 to
92a850c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #710 +/- ##
==========================================
- Coverage 79.41% 79.24% -0.18%
==========================================
Files 525 525
Lines 9470 9533 +63
Branches 32 30 -2
==========================================
+ Hits 7521 7554 +33
- Misses 1949 1979 +30
☔ View full report in Codecov by Sentry. |
|
I regret to inform you that this is ready for review. |
swalker2m
approved these changes
Oct 16, 2023
| @@ -3169,7 +3182,7 @@ type RecordGmosSouthVisitResult { | |||
| Right Ascension, choose one of the available units | |||
| """ | |||
| input RightAscensionInput { | |||
| microarcseconds: Long @deprecated | |||
| microarcseconds: Long | |||
There was a problem hiding this comment.
You can't deprecate fields on input types. Grackle now recognizes this and rejects the schema if you try. Maybe I should just take the opportunity to remove the field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the ODB to Grackle 0.14, which improves query elaboration via an
Elabmonad that replaces manual AST manipulation in many cases. There are also a few changes to accommodate changes in lucuma-graphql-routes and some minor reorg in Grackle.