SmartGCal support for Flamingos2 #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cquiroz
commented
Jan 21, 2025
|
|
||
| object Flamingos2: | ||
|
|
||
| case class SearchKey( |
There was a problem hiding this comment.
This is taken from Gmos, I'm not sure if I need a separate SearchKey and TableKey
There was a problem hiding this comment.
I'm struggling to remember why I thought I needed distinct types for GMOS. It may be that the search key once separated the wavelength. I'm not sure. If you don't see a need for the distinction by all means merge them.
swalker2m
reviewed
Jan 21, 2025
| PRIMARY KEY (c_instrument, c_gcal_id), | ||
|
|
||
| FOREIGN KEY (c_instrument, c_gcal_id) REFERENCES t_gcal(c_instrument, c_gcal_id), | ||
| CONSTRAINT check_is_gmos_south CHECK (c_instrument = 'Flamingos2'), |
We'll need to update the |
cquiroz
force-pushed
the
sc-4541-add-smartgcal-support-for-f2-ls
branch
from
14cf165 to
6d1971c
Compare
toddburnside
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for review I still need to do a core release before merging.
@swalker2m This is what I found was needed for SmartGCal but maybe I'm missing something else?