Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify proposal title and program name #1559

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Conversation

swalker2m
Copy link
Contributor

There are two goals expressed in ShortCut 2422:

  • Remove the duplication between program name and proposal title
  • Make it possible to add an abstract to all programs, even if they don't go through a TAC process

Accordingly I made these changes:

  • Removed the proposal title in favor of the existing program name. Whether a program has a proposal or not it can have a name.
  • Removed the proposal abstract and added a program description. This allows all programs to have a description, matches the name and description fields of Group, and removes the clashes-with-scala term abstract.

I expect the existing Proposal title and abstract to map to Program name and description. Does this sound okay or do we want to keep title and abstract and just move them to Program.

Copy link
Contributor

@toddburnside toddburnside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. It will, of course, break explore. I'll check with Andy to see how he wants the UI to work.

@toddburnside
Copy link
Contributor

Since the program name and description are used for the proposal now, should the API prevent editing of name and description if there is a proposal and it is Submitted or Accepted?

@swalker2m swalker2m force-pushed the remove-proposal-title branch from a648327 to 978eb5a Compare January 23, 2025 10:44
@toddburnside toddburnside merged commit 5012832 into main Jan 24, 2025
6 checks passed
@toddburnside toddburnside deleted the remove-proposal-title branch January 24, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants