Add centralWavelength to GMOS steps
#1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swalker2m
force-pushed
the
central-wavelength
branch
from
ac3c0e4 to
c04706a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
centralWavelengthto JSON steps as requested in ShortCut 4491.Central wavelength is taken from the grating config (if present) and otherwise from the filter (if present). It will be
nullif neither are specified in the GMOS dynamic config. There are two places where updates are required:To simplify the second item, I updated the GMOS dynamic config views to include a computed
c_central_wavelengthcolumn.