Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FutureWarning in pretrained.py by setting weights_only=True in torch.load #62

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thunn
Copy link

@thunn thunn commented Oct 31, 2024

Description:
This PR updates the torch.load call in vocos\pretrained.py to set weights_only=True, following PyTorch's guidance for mitigating potential security risks with pickle deserialization in untrusted environments. (as noted in #61)

  • Tested on PyTorch v2.4.1 with no warning output

@thunn
Copy link
Author

thunn commented Nov 25, 2024

Hi @hubertsiuzdak,

Thank you for your work on this project! This MR addresses a FutureWarning when using vocos. Could you kindly review and merge it if possible? Let me know if any changes are needed.

Appreciate your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant