Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technical Correction 3.0.1 #141

Merged
merged 10 commits into from
Jan 5, 2024
Merged

Technical Correction 3.0.1 #141

merged 10 commits into from
Jan 5, 2024

Conversation

f-peverali
Copy link
Contributor

@f-peverali f-peverali commented Jan 3, 2024

Version Upgrade Template

Version: 3.0.1

Date: 3.1.2024

Description

This is a Pullreuqest that requires an increase in the Version number. Therefore, multiple outside-github, related Task have to be performed and checked.

All jobs with an x in the boxes were performed to the best of knowledge.

Pre-Merge Activities

  • This PR refers to a versioned Branch with a name and a version number in the form of N.n.n, e.g. "TC_3.2.1".

  • This PR has a clean meaningful commit history. Minor commits or commits without description have been squashed, at the latest now.

  • The ./github/workflows/main.yml refers to the correct Firely Terminal and SUSHI Version.

    Firely Terminal Pipeline 0.4.0.

    SUSHI Versions 3.5.0.

  • By running the Release_Publish.py script, release version and date was updated accordingly. The script ran without errors.

  • Eventually, increase the dependency of to newer Basis Modul (package and sushi-config)

  • New Release Notes were created, alined to the commit history and cleaned. In Github, go to

    • -> Releases then -> Draft a new release with the Modul Name and Version, then
    • -> Target the main-Branch and ->enter a new Tag according to the Version, then click.
    • Click -> Generate Release notes , ->Adjust them if necessary and -> Copy/Paste the Details in the RealeaseNotes.md of the very Branch you want to merge.
    • Finally -> Save as Draft

Merge and Publishing

  • With the updated Version, Dates, and Release Notes (as described above) with the last committ into the Branch you want to merge.
  • In GitHub -> Actions the ->CI (FHIR Validation) workflow terminates successfully.
  • Add the Approve / the PR gets positively reviewed by a colleague.
  • Merge (without squash) the PR, delete the Branch.

Post-Merge Activities

  • Go to the corresponding SIMPLIFIER Project and -> Github -> Reimport the project.
  • Go to the corresponding SIMPLIFIER Project and -> Packages -> Expand the Dropdown for Create -> Create new package for the project.
    • With the corresponding version number, and
    • The Release notes (from above) and a compare-link to the previous Release.
    • Unlist the old package by -> clicking on the old package, -> go to Administration and -> click on Unlist
  • Publish the previously drafted Release, including version number, on GitHub.
  • Provide / Archive the IG in the corresponding gh-pages branch of the GitHub project.
    • Checkout the Branch (no need to merge it later).
    • Export from Simplifier via -> Guides -> Expand the Modul ... -> Export
    • Unpack the zip, remove the packages folder (because its kinda big), and move everything else to a (version corresponding) new folder in the branch folder structure.
    • Update the file index.html and check rendering
    • commit the branch.
  • If ISiK Basismodul was updated all depending Modules should be updated with a renewed dependency to the incremented Basismodul version - possibly including and closing technical corrections

Finished

Sorry, something went wrong.

@f-peverali f-peverali marked this pull request as draft January 3, 2024 10:44
@f-peverali f-peverali changed the title update dependency ISIK Basis Technical COrrection 3.0.1 Jan 3, 2024
@f-peverali f-peverali changed the title Technical COrrection 3.0.1 Technical Correction 3.0.1 Jan 3, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* add link to Basis + fix Link+typos

* Update sushi-config.yaml

* issue and pr templates

* fixing r4 references (#134)

* add profile steatement

* Update ImplementationGuide/markdown/AnmerkungenMS.md

Co-authored-by: Yannick Börner <[email protected]>

* Update ImplementationGuide/markdown/CapabilityStatement.md

Co-authored-by: Yannick Börner <[email protected]>

* Update ImplementationGuide/markdown/CapabilityStatement.md

Co-authored-by: Yannick Börner <[email protected]>

* Update ImplementationGuide/markdown/CapabilityStatement.md

Co-authored-by: Yannick Börner <[email protected]>

* Update ImplementationGuide/markdown/Interaktionen.md

Co-authored-by: Yannick Börner <[email protected]>

* Update ImplementationGuide/markdown/Interaktionen.md

Co-authored-by: Yannick Börner <[email protected]>

* Update ImplementationGuide/markdown/Interaktionen.md

Co-authored-by: Yannick Börner <[email protected]>

* Update Resources/sushi-config.yaml

---------

Co-authored-by: Max Theilig <[email protected]>
Co-authored-by: Yannick Börner <[email protected]>
@f-peverali f-peverali requested a review from alexzautke January 5, 2024 08:40
@f-peverali f-peverali marked this pull request as ready for review January 5, 2024 08:50

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@f-peverali f-peverali requested a review from alexzautke January 5, 2024 09:23
alexzautke
alexzautke previously approved these changes Jan 5, 2024
@f-peverali f-peverali merged commit 29266ee into main-stufe-3 Jan 5, 2024
2 checks passed
@f-peverali f-peverali deleted the TC_3.0.1 branch January 5, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants