Rework playback architecture a bit, use nanoseconds everywhere #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice :) There were some bugs in the past caused by nanosecond / second confusion so good thing to decide for one. |
|
I think this is good to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was kinda weird, that the setter for
Player.positionexpected seconds, but the getter returned nanoseconds. Now every such interface should use nanoseconds, as that's what GStreamer uses internally, and we also don't have to care about floating point numbers.The database still uses seconds in some places though, but it's better this way, so no database migration is needed.
Also some bug fixes