Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI String Improvements #914

Merged
merged 2 commits into from
Jun 1, 2024
Merged

UI String Improvements #914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbc3639
ui: Improve remove strings
yakushabb Apr 26, 2024
09780a6
ui: Make some strings GNOME HIG compatible
yakushabb Apr 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cozy/ui/delete_book_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ class DeleteBookView(Adw.AlertDialog):

def __init__(self, callback, book: Book):
super().__init__(
heading=_("Delete Audiobook?"),
body=_("The audiobook will be removed from your disk and from Cozy's library."),
heading=_("Permanently Delete Audiobook?"),
body=_("The audiobook will be permanently deleted from your device and cannot be recovered"),
default_response="cancel",
close_response="cancel",
)

self.add_response("cancel", _("Cancel"))
self.add_response("delete", _("Remove Audiobook"))
self.add_response("delete", _("Delete"))
self.set_response_appearance("delete", Adw.ResponseAppearance.DESTRUCTIVE)

list_box = Gtk.ListBox(margin_top=12, css_classes=["boxed-list"])
Expand Down
2 changes: 1 addition & 1 deletion cozy/ui/file_not_found_dialog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def __init__(self, chapter: Chapter):
self.missing_chapter = chapter

super().__init__(
heading=_("File not found"),
heading=_("File Not Found"),
body=_("This file could not be found. Do you want to locate it manually?"),
default_response="locate",
close_response="cancel",
Expand Down
6 changes: 3 additions & 3 deletions cozy/ui/widgets/book_element.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,13 @@ def _create_context_menu(self):
menu_model = Gio.Menu()

self.install_action("book_element.mark_as_read", None, self._mark_as_read)
menu_model.append(_("Mark as read"), "book_element.mark_as_read")
menu_model.append(_("Mark as Read"), "book_element.mark_as_read")

self.install_action("book_element.jump_to_folder", None, self._jump_to_folder)
menu_model.append(_("Open in file browser"), "book_element.jump_to_folder")
menu_model.append(_("Open in File Browser"), "book_element.jump_to_folder")

self.install_action("book_element.remove_book", None, self._remove_book)
menu_model.append(_("Remove from library"), "book_element.remove_book")
menu_model.append(_("Permanently Delete…"), "book_element.remove_book")

menu = Gtk.PopoverMenu(menu_model=menu_model, has_arrow=False)
menu.set_parent(self.art)
Expand Down
2 changes: 1 addition & 1 deletion data/ui/main_window.blp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ Adw.ApplicationWindow app_window {
}

Adw.NavigationPage {
title: _("Book title");
title: _("Book Title");
tag: 'book_overview';

child: Adw.ToolbarView book_details_container {};
Expand Down
2 changes: 1 addition & 1 deletion data/ui/preferences.blp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ template $PreferencesWindow: Adw.PreferencesDialog {
title: _("Feedback");

Adw.PreferencesGroup user_feedback_preference_group {
title: _("User feedback");
title: _("User Feedback");
}
}
}
4 changes: 2 additions & 2 deletions data/ui/search_page.blp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ using Adw 1;
template $SearchView: Adw.Bin {
Stack stack {
Adw.StatusPage start_searching_page {
title: _("Search in your library");
title: _("Search in Your Library");
icon-name: 'library-symbolic';
}

Adw.StatusPage nothing_found_page {
title: _("No results found");
title: _("No Results Found");
icon-name: 'edit-find-symbolic';
}

Expand Down
2 changes: 1 addition & 1 deletion data/ui/storage_locations.blp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ using Gtk 4.0;
using Adw 1;

template $StorageLocations: Adw.PreferencesGroup {
title: _("Storage locations");
title: _("Storage Locations");

ListBox storage_locations_list {
margin-bottom: 18;
Expand Down