Modernize storage list #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO:
|
naglis
reviewed
Dec 21, 2023
Co-authored-by: Naglis Jonaitis <[email protected]>
geigi
reviewed
Jan 19, 2024
|
|
||
| model.delete() | ||
| self._model.invalidate() | ||
| self.emit_event("storage-removed", model) |
There was a problem hiding this comment.
When removing a storage location we previously also removed all files from our db that originated from this location. This is currently handled by the _on_settings_event function in the library_view_model. I think we propably should move the deletion of the db entries from the library_view_model to the storages_view_model. But I'm not sure if we need to do something additional that the UI get's updated correctly.
There was a problem hiding this comment.
Done. Seems like updating the UI works fine.
There was a problem hiding this comment.
I guess this also fixes #151 then?
There was a problem hiding this comment.
Awesome :) I'll test it again and will close the issue if it's resolved :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernize storage list, so that it uses libadwaita widgets, works correctly on mobile and some other stuff.
In the process I also refactored the storages part of the settings view model into its own VM.
Ohh, and another change for the fadeout settings row in 9693858