Dynamically generate about dialog from metainfo #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdbende
commented
Dec 4, 2023
| # Icon | ||
| - Jakub Steiner | ||
|
|
||
| # Translators |
There was a problem hiding this comment.
Translators section is to be removed after the PO files have been updated
There was a problem hiding this comment.
How will the PO files need to be updated? Will the translators be shown automatically in the about dialog?
There was a problem hiding this comment.
about.set_translator_credits(_("translator-credits"))There's the "translator-credits" string which translators can localize, so only the translators relevant to that language will show up in the about window. (docs)
Actually, it might be a good idea to still list all translators somewhere, though AUTHORS.md is probably not the best place for it.
|
TODO: Make sure to also merge #839 into this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked as draft as it depends on #799.