UI String Improvements #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yakushabb
force-pushed
the
fix-delete-action
branch
from
5ff8fe1 to
a5cf764
Compare
Change the 'Remove from library' strings to 'Permanently delete' to make the action clearer for the user, informing them that the action will delete user files and cannot be recovered. Fixes geigi#912
Use header capitalization for menu entries and titles. More information: https://developer.gnome.org/hig/guidelines/writing-style.html
yakushabb
force-pushed
the
fix-delete-action
branch
from
a5cf764 to
09780a6
Compare
|
I'll merge this, but keep #912 open, as I think it would be still better to have not remove them, and have a blacklist instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ui: Improve remove strings
Change the 'Remove from library' strings to 'Permanently delete' to make the action clearer for the user, informing them that the action will delete user files and cannot be undone.
Fixes #912
ui: Make some strings GNOME HIG compatible
Use header capitalization for menu entries and titles.
More information: https://developer.gnome.org/hig/guidelines/writing-style.html