fix: copy the metadata of the ImageCollection when copying an asset #388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #371
It was much more complicated than I though.
Setting the
system:time_start
of the ImageCollection is forcing me to jump in 3 differnet naming convention:startTime
in thegetAsset
methodstart_time
in theupdateAsset
methodsystem:time_start
(still camel case but reversed) inee.imageCollection.propertynames
In this PR I upgraded the
setProperties
so it supports all type of properties (system and normal) and tay consistent with the server API convention (system:time_start).I then added extra steps in the
copy
method to retreivestartTime
from the original asset and pass it in the correct format.I also reported my findings on the Google issue tracker: https://issuetracker.google.com/issues/381535044