Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display doy graph using month start names #364

Merged
merged 2 commits into from
Nov 4, 2024
Merged

fix: display doy graph using month start names #364

merged 2 commits into from
Nov 4, 2024

Conversation

12rambau
Copy link
Member

@12rambau 12rambau commented Oct 27, 2024

Fix #361

As graphs are meant to be shared, I'm not 100% sure doy is actually the easiest way to convey information to non expert users. Also have a day prescision might not be the key information when looking as seasonal trends. I propose in this PR to change the x-axis of dates in doy related graphs to get the month names ticks instead.

I doesn't change the raw data structure at all (it still displays doy values) but only the ticks that are build on top of the year 2023 year. The graph will be off by 1 day if you deal with leap years but that's already the case in the doy themselves.

Here is a comparison of the 3 aftected example graphs:

Before After

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.15%. Comparing base (819dbda) to head (80c9dd7).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #364      +/-   ##
==========================================
+ Coverage   91.13%   91.15%   +0.02%     
==========================================
  Files          27       27              
  Lines        1646     1651       +5     
  Branches       75       75              
==========================================
+ Hits         1500     1505       +5     
  Misses        127      127              
  Partials       19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@12rambau 12rambau merged commit a45bdb1 into main Nov 4, 2024
12 checks passed
@12rambau 12rambau deleted the doy branch November 4, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

display days as date on the doy graphs
1 participant