-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve maskCover #349
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a geometry. maskCoverRegions does the same but inside a FeatureCollection.
12rambau
requested changes
Oct 22, 2024
12rambau
requested changes
Oct 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #349 +/- ##
==========================================
- Coverage 91.16% 91.10% -0.07%
==========================================
Files 26 27 +1
Lines 1415 1641 +226
Branches 68 75 +7
==========================================
+ Hits 1290 1495 +205
- Misses 108 127 +19
- Partials 17 19 +2 ☔ View full report in Codecov by Sentry. |
12rambau
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, this function was designed to compute the percentage of masked pixels inside a geometry. This allows the user to compute a similar value to
"CLOUD_COVER"
property in Landsat scenes or"CLOUD_COVERAGE_ASSESSMENT"
in Sentinel 2 scenes, but in a specific region instead of the whole scene. When creating composites we could discard "good" pixels if we filter the collection using the cloud cover property of the scene, but using this method we can discard pixels of regions with high percentage of masked pixels.The method has been divided in two methods:
maskCoverRegion
: computes the value using aee.Geometry
maskCoverRegions
: computes the value in eachee.Feature
of aee.FeatureCollection
This method can also be helpful in the creation of composites using unbounded images, like MODIS.
The param
scale
is to avoid using too much resources to compute this value when a rough computation is enough.