-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a bump-only command #59
base: master
Are you sure you want to change the base?
Conversation
If you use both |
Yes. If you're planning to use |
Oh, I see... 😳 Thanks. |
No problemo. Nice shirt, btw ⚾ |
👍 |
Another case that leads me to believe all the tasks should be separated out so you can run separately. |
@@ -10,8 +10,16 @@ var shell = require('shelljs'); | |||
var semver = require('semver'); | |||
|
|||
module.exports = function(grunt){ | |||
grunt.registerTask('bump-only', 'bump version only', function(type){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be registerMultiTask
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also change bump-only
to release-bump
since bump
is a subset of release
and I believe we should "namespace" it here.
Thanks for the contribution. I am not sure if there is a real use-case for this feature. Do you want to commit and tag stuff before you run your build job? I don't think so. Your release might be buggy. |
I have a use case for this actually, I was using the version from package.json in a comment that is written into the concatenated and minified output files. It is now one version off and it isn't JSON so i can't simply tack it into additionalFiles. It would be cool if we could scan through files looking for a pattern like <% version %> or something and replace it as well as package.json/bower.json. |
6e0c17a
to
195e82f
Compare
@scottux I use the string-replace grunt package to do exactly what you are talking about. |
This adds the ability to do a two-step release, a la:
This is an enviable feature of
grunt-bump
. Would also resolve #53There weren't many tests to code against, so I'd love some help on that front in case I missed anything obvious.