Fix to an undef error #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the _get_js_sock function returns undef, it is placed into the loaned_sock property inside _get_loaned_sock. This can cause 'Can't call method "close" on an undefined value' later on; so, don't put undef in there, and don't die when the value is undef.
p-alik
added a commit
to p-alik/perl-Gearman-Client
that referenced
this pull request
Oct 23, 2016
add repository to dist metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the _get_js_sock function returns undef, it is placed into the
loaned_sock property inside _get_loaned_sock. This can cause
'Can't call method "close" on an undefined value' later on; so, don't
put undef in there, and don't die when the value is undef.
Full(er) exception from real use:
Internal error in request handler : Can't call method "close" on an undefined value at REDACTED line XXX
REDACTED('Can't call method "close" on an undefined value at /usr/lib/...') called at /usr/lib/perl5/site_perl/5.X.Y/Gearman/Taskset.pm line 87
Gearman::Taskset::cancel('Gearman::Taskset=ARRAY(0x2190b3d0)') called at /usr/lib/perl5/site_perl/5.X.Y/Gearman/Taskset.pm line 142
Gearman::Taskset::wait('Gearman::Taskset=ARRAY(0x2190b3d0)', 'timeout', 0.2) called at REDACTED line XXX