Completed HW 01 of Gear Academy #55
Conversation
There was a problem hiding this comment.
Please make a PR to be merged into your repo (https://github.com/jonar12/dapps-template-gear-academy) instead of the template.
Please reread the homework rules: https://academy.gear.rs/getting-started/homework-rules
Note that the target branch for the PR should be
masterin your repository, not in the template one.
Also, please be sure your CI workflow passes before sending the PR.
| name); | ||
|
|
||
| let tamagotchi = Tamagotchi { | ||
| name: name.clone(), |
There was a problem hiding this comment.
No need to clone the name, it is better to move it.
| name: name.clone(), | |
| name, |
| msg::reply( | ||
| TmgEvent::Name(name), | ||
| 0 | ||
| ).unwrap(); |
There was a problem hiding this comment.
This reply is not defined in metadata, it is pretty senseless.
| msg::reply( | |
| TmgEvent::Name(name), | |
| 0 | |
| ).unwrap(); |
| msg::reply(TmgEvent::Name(tmg.name.clone()), 0).expect("Name not loaded correctly"); | ||
| } | ||
| TmgAction::Age => { | ||
| msg::reply(TmgEvent::Age(tmg.date_of_birth.clone()), 0).expect("Age not loaded correctly"); |
There was a problem hiding this comment.
No need to clone Copy types. Also, Age should depend on the current block timestamp.
| let res = _program.send(2, TmgAction::Age); | ||
| assert!(!res.log().is_empty()); |
There was a problem hiding this comment.
You could write a more expressive test by using the System::spend_blocks function.
No description provided.