completed smart contract section #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamilsan
suggested changes
Jan 14, 2024
There was a problem hiding this comment.
Please make a PR to be merged into your repo (https://github.com/kenocathon/dapps-template-gear-academy/) instead of the template.
Please reread the homework rules: https://academy.gear.rs/getting-started/homework-rules
Note that the target branch for the PR should be
masterin your repository, not in the template one.
Also, please be sure your CI workflow passes before sending the PR.
Comment on lines
+6
to
+7
|
|
||
|
|
There was a problem hiding this comment.
Please use cargo fmt before committing.
Suggested change
| TmgAction::Age => { | ||
| debug!("Tamagotchi: Age Requested"); | ||
| // Directly reply with the date of birth, as TmgAction::Age does not carry data | ||
| msg::reply(TmgEvent::Age(state.date_of_birth), 0) |
There was a problem hiding this comment.
Age should depend on the current block timestamp.
| #[no_mangle] | ||
| extern fn state() { | ||
| // TODO: 7️⃣ Return the Tamagotchi state | ||
| let tomagotchi = unsafe { |
There was a problem hiding this comment.
Typo:
Suggested change
| let tomagotchi = unsafe { | |
| let tamagotchi = unsafe { |
|
|
||
| assert!(!get_name_result.main_failed(), "Name request failed"); | ||
|
|
||
| let expected_tamagatchi = Log::builder() |
There was a problem hiding this comment.
Typo
Suggested change
| let expected_tamagatchi = Log::builder() | |
| let expected_tamagotchi = Log::builder() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished the homework and uploaded program to the testnet blockchain. Recieved a new tomagatchi as expected.