Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ZIP display bug #313

Merged
merged 6 commits into from
May 14, 2024
Merged

Fix ZIP display bug #313

merged 6 commits into from
May 14, 2024

Conversation

Cosmin765
Copy link
Collaborator

Fixed 2 issues:

  • we can now support ZIPs that don't have the parent directory as a standalone entry
  • ensure the displayed files actually belong to the shown directory - before, the only check was that the parent directory is a prefix of the file's path, but this is insufficient

@Cosmin765 Cosmin765 linked an issue May 10, 2024 that may be closed by this pull request
BUG Incorrect display for docx archives #312
Closed
@rzaharia rzaharia requested review from rzaharia May 14, 2024 12:26
@gheorghitamutu gheorghitamutu merged commit 9a934de into main May 14, 2024
5 of 6 checks passed
@gheorghitamutu gheorghitamutu deleted the 312-bug-incorrect-display-for-docx-archives branch May 14, 2024 12:27
@gheorghitamutu gheorghitamutu added the Bug Something isn't working label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gheorghitamutu gheorghitamutu gheorghitamutu approved these changes

@rzaharia rzaharia Awaiting requested review from rzaharia

Assignees

@Cosmin765 Cosmin765

Labels
Bug Something isn't working
Projects
GView
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG Incorrect display for docx archives
3 participants
@Cosmin765 @rzaharia @gheorghitamutu