[LNK] # add default value on unknown extra data signature type #335

gdt050579 · Aug 17, 2024 · f1331c4 · f1331c4
1 parent f80958d
commit f1331c4
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/Types/LNK/include/Internal.hpp b/Types/LNK/include/Internal.hpp
@@ -1818,4 +1818,13 @@ static std::string_view GetNameFromGUID(const MyGUID& guid)
 
     return "Unknown";
 }
+
+static std::string_view GetExtraDataSignaturesName(ExtraDataSignatures type) {
+    if (LNK::ExtraDataSignaturesNames.contains(type)) {
+        return LNK::ExtraDataSignaturesNames.at(type);
+    }
+
+    return "?Signature";
+}
+
 } // namespace GView::Type::LNK
diff --git a/Types/LNK/src/LNK.cpp b/Types/LNK/src/LNK.cpp
@@ -92,7 +92,7 @@ extern "C"
 
         for (const auto& extraData : lnk->extraDataBases)
         {
-            const auto& name = LNK::ExtraDataSignaturesNames.at(extraData->signature);
+            const auto& name = LNK::GetExtraDataSignaturesName(extraData->signature);
             const auto& c    = *(colors.begin() + (count % 2));
             settings.AddZone(offset, extraData->size, c, name.data());
             count++;

diff --git a/Types/LNK/src/Panels/ExtraData.cpp b/Types/LNK/src/Panels/ExtraData.cpp
@@ -66,7 +66,7 @@ void ExtraData::UpdateGeneralInformation()
 
 void ExtraData::UpdateExtraDataBase(ExtraDataBase* base)
 {
-    const auto& signatureName = LNK::ExtraDataSignaturesNames.at(base->signature).data();
+    const auto& signatureName = LNK::GetExtraDataSignaturesName(base->signature).data();
 
     general->AddItem(signatureName).SetType(ListViewItem::Type::Category);