[2주차] 최서현 : 게시글 조회/생성 api #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
과제 요구조건 잘 지켜서 잘 코딩해주신 것 같아요! 👍👍 |
base 브랜치가 main으로 되어있는데 개인 브랜치로 바꿔주세요!
|
HwanGonJang
reviewed
Jun 19, 2024
|
|
||
| public List<PostDto> getAllPosts() { | ||
| List<Post> posts = postRepository.findAll(); | ||
| return posts.stream().map(PostDto::from).collect(Collectors.toList()); |
There was a problem hiding this comment.
List 엔티티 객체를 dto로 변환하는 것도 따로 빼서 메소드로 만들어주면 좋을 것 같아요!
HwanGonJang
reviewed
Jun 19, 2024
Comment on lines
+17
to
+25
| public static PostDto from(Post post) { | ||
| return PostDto.builder() | ||
| .id(post.getId()) | ||
| .title(post.getTitle()) | ||
| .content(post.getContent()) | ||
| .createdAt(post.getCreatedAt()) | ||
| .updatedAt(post.getUpdatedAt()) | ||
| .build(); | ||
| } |
There was a problem hiding this comment.
indent가 8개, 4개가 혼용되고 있네요. 4자로 일정하면 좋을 것 같아요. 인텔리제이 Actions on save 설정하면 설정한 indent 수로 자동 포맷팅을 해줍니다:)
| @RestController | ||
| @RequestMapping("/posts") | ||
| public class PostController { | ||
| @Autowired |
There was a problem hiding this comment.
스프링이 자동으로 injection을 해주기 때문에 @Autowired는 빼도 됩니다. 전에 범수님이 발표한 것처럼 빌드타임에서의 오류를 잡기 힘들다던가 하는 점들이 있어서 이런 상황에서는 안쓰는게 좋아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
게시글 조회/생성 api