Skip to content

Commit

Permalink
Merge pull request #160 from gdrplatform/GDR-2558.2
Browse files Browse the repository at this point in the history
refactor: utilize calc_sd function
  • Loading branch information
bczech authored Aug 20, 2024
2 parents 7c0295c + 990edd4 commit 3433ac7
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 5 deletions.
6 changes: 3 additions & 3 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ Type: Package
Package: gDRcore
Title: Processing functions and interface to process and analyze drug
dose-response data
Version: 1.3.9
Date: 2024-08-09
Version: 1.3.10
Date: 2024-08-19
Authors@R: c(
person("Bartosz", "Czech", , "[email protected]", role = "aut",
comment = c(ORCID = "0000-0002-9908-3007")),
Expand All @@ -29,7 +29,7 @@ Imports:
BiocParallel,
checkmate,
futile.logger,
gDRutils (>= 1.1.14),
gDRutils (>= 1.3.9),
MultiAssayExperiment,
purrr,
stringr,
Expand Down
3 changes: 3 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## gDRcore 1.3.10 - 2024-08-19
* utilize `calc_sd` function

## gDRcore 1.3.9 - 2024-08-09
* fix issue with wrong mapping of Day0 data

Expand Down
2 changes: 1 addition & 1 deletion R/average_SE.R
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ average_FUN <- function(x,
unmasked <- x[!masked, , drop = FALSE]
agg_df <- unmasked[, list(mean(x, na.rm = TRUE),
# set sd = 1 for single values
ifelse(length(x) == 1, 0, sd(x, na.rm = TRUE))),
gDRutils::calc_sd(x)),
by = c("normalization_type", series_identifiers)]
data.table::setorderv(agg_df, c(series_identifiers, "normalization_type"))
data.table::setnames(agg_df, c("V1", "V2"), c("x", "x_std"))
Expand Down
2 changes: 1 addition & 1 deletion rplatform/dependencies.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
pkgs:
gDRutils:
ver: '>= 1.1.14'
ver: '>= 1.3.9'
url: gdrplatform/gDRutils
ref: main
subdir: ~
Expand Down

0 comments on commit 3433ac7

Please sign in to comment.