Merge pull request #167 from gdrplatform/bioc_fix151124

gdrplatform · Nov 15, 2024 · 084282a · 084282a
2 parents 0e45c64 + e721e72
commit 084282a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -2,8 +2,8 @@ Type: Package
 Package: gDRcore
 Title: Processing functions and interface to process and analyze drug
     dose-response data
-Version: 1.5.1
-Date: 2024-11-05
+Version: 1.5.2
+Date: 2024-11-15
 Authors@R: c(
     person("Bartosz", "Czech", , "[email protected]", role = "aut",
            comment = c(ORCID = "0000-0002-9908-3007")),

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,6 @@
+## gDRcore 1.5.2 - 2024-11-15
+* fix melt in annotation function to fix Bioc error
+
 ## gDRcore 1.5.1 - 2024-11-05
 * synchronize Bioconductor and GitHub versioning
 

diff --git a/R/add_annotation.R b/R/add_annotation.R
@@ -294,9 +294,9 @@ get_drug_annotation_from_dt <- function(dt) {
                                                                   unlist(drug_cols[c("drug",
                                                                                      "drug_name",
                                                                                      "drug_moa")])))),
-                              value.name = unlist(drug_cols[c("drug",
-                                                              "drug_name",
-                                                              "drug_moa")]))
+                              value.name = as.character(unlist(drug_cols[c("drug",
+                                                                           "drug_name",
+                                                                           "drug_moa")])))
   dt_long[, "variable" := NULL]
   unique_dt <- unique(dt_long)
   unique_dt[!unique_dt[[drug_cols[["drug"]]]] %in% gDRutils::get_env_identifiers("untreated_tag"), ]