[FEAT] 필요한 protobuf 파일 정의 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jyoo0515
commented
Feb 15, 2024
jyoo0515
commented
- api 윤곽을 잡기 위해 protobuf 작업부터 올립니다
- Articulation: 문장 구사 연습
- Pronunciation: 발음 구사 연습
- History 는 type 을 받으면 그 타입만, 안받으면 모든 타입 섞어서 내려주는걸 생각중
C-limlim
reviewed
Feb 15, 2024
proto/articulation.proto
Outdated
Comment on lines
6
to
9
| message ContextDTO { | ||
| int32 id = 1; | ||
| string image_url = 2; | ||
| } |
There was a problem hiding this comment.
그때 예시 봤을 때 이미지 + 이미지를 보고 답할 수 있는 질문들 구성인 것 같은데 질문도 같이 내려줘야할지도?
There was a problem hiding this comment.
그러고보니 우리의 귀요미 캐릭터 동영상은 어떻게 하기로 했었죠?...
namooplus
reviewed
Feb 17, 2024
proto/articulation.proto
Outdated
There was a problem hiding this comment.
articulation의 의미가 문장 구사보다는 발음 명료성에 가까운 거 같아서 다른 워딩을 쓰는 게 좋지 않을까 생각!
(formation, contextual feedback 등...?)
namooplus
reviewed
Feb 17, 2024
namooplus
reviewed
Feb 17, 2024
proto/articulation.proto
Outdated
| // information for articulation practice | ||
| message SceneDTO { | ||
| int32 id = 1; | ||
| string image_url = 2; |
namooplus
reviewed
Feb 17, 2024
proto/topic.proto
Outdated
Comment on lines
13
to
14
| repeated SentenceDTO sentences = 4; | ||
| repeated SceneDTO scenes = 5; |
There was a problem hiding this comment.
여기서 전체 sentence나 scene을 내려주기보단 sentenceIds, sceneIds를 내려주고 클라이언트에서 id로 step마다 id 하나씩 get 요청하는 게 나을 것 같아
There was a problem hiding this comment.
firestore 에서 데이터 넣다 보니까 id 가 다 string 이라 string 으로 통일함
7d682c2
namooplus
approved these changes
Feb 18, 2024
proto/feedback.proto
Outdated
|
|
||
| message CommunicationFeedbackDTO { | ||
| string scene_id = 1; | ||
| string overall_feedback = 5; |
Co-authored-by: namoo (Ian) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.