[FEAT] sentence, sentence_feedback proto 추가 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
C-limlim
commented
Jan 28, 2024
C-limlim
commented
- sentence와 sentence feedback 담당 proto 분리
- 오디오파일 전송은 todo로 작서
- lint룰에 맞게 수정
namooplus
approved these changes
Jan 28, 2024
| int32 speed_score = 3; | ||
| int32 volume_score = 4; | ||
| string feedback_text = 5; | ||
| //ToDo: add feedback audio file |
There was a problem hiding this comment.
https://protobuf.dev/programming-guides/proto3/#fieldreserved
reserved 쓰면 미리 property 정의하는 것도 가능합니다~!
There was a problem hiding this comment.
@jyoo0515 reserved 6; 어떻게 생각하시나요?
Comment on lines
+8
to
+9
| int32 speed_score = 3; | ||
| int32 volume_score = 4; |
There was a problem hiding this comment.
요거는 각각 1이면 느리다/작다, 5면 빠르다/크다 정도(1~5)로 내려오는 걸까용
There was a problem hiding this comment.
중요한 지적인 것 같아요
- pronouncation_score: api 응답, 확실하진 않지만 0 -5 사이의 정수
- speed_score, volumne_score: 계산으로 도출, range를 정하지 않았음
enum으로 할 수도 있지만 1 - 5 로 나누면 2는 '조금 작음' 일수도 있는데 그게 얼마나 효과적일지 모르겠어서 일단 int32 정의하는거로 했습니다
1 - 5 로 내려오면 언급한대로 내려올듯요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.